fix(test-runner): consider dependency project tests when applying --last-failed#41622
fix(test-runner): consider dependency project tests when applying --last-failed#41622Git-Raini wants to merge 1 commit into
Conversation
…ast-failed Previously only top-level projects were checked against post-shard filters like --last-failed before dependency projects got prepended to the root suite. If the only projects with matching tests were classified as dependencies (e.g. because another project lists them in `dependencies`), the top-level projects had no matching tests, got filtered out entirely, and dependencies never got a chance to run, producing "No tests found". Fixes: microsoft#39811
|
Thanks, but this isn't the right fix. The change makes the top-level-vs-dependency classification depend on The root cause is that dependency projects are pruned before post-shard filters are applied — the fix belongs there, not in the top-level predicate. Closing for now. |
|
Thanks for the detailed review, @yury-s - pushed a new commit (c09c9d63d) that addresses this directly:
Test results ( Also ran the full I don't have permission to reopen this PR myself (looks like GitHub restricts that to whoever closed it) - happy to have it reopened for another look, or let me know if you'd like anything else adjusted. |
Fixes #39811